feat: add Milvus memory service#167
Conversation
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
|
Updated the integration coverage with live embedding-provider E2E tests for both Milvus Lite and Zilliz Cloud, while keeping the deterministic embedding tests for stable local/CI smoke coverage. Local validation:
The skipped live embedding checks are for a provider endpoint that is unavailable from the current location. |
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
|
Tightened the live integration tests so external services are fully opt-in. Having credentials in the environment is no longer enough to trigger network-backed Milvus/Zilliz/OpenAI/Google checks; callers must also set the relevant I also expanded the Milvus memory sample to clarify that the service accepts any embedding function, with both Gemini and OpenAI embedding examples. Local validation:
|
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
|
Added the RAG side of the Milvus integration in a separate commit. What changed:
Validation:
|
|
Hi @DeanChensj and @secprog, this is ready for review when you have a chance. This implements the Milvus memory and RAG toolset support in the community repo, including the use case from #70, with opt-in live E2E coverage for Milvus Lite and Zilliz Cloud. The companion docs PR is google/adk-docs#1924. |
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
|
Hi @DeanChensj @secprog, friendly follow-up when you have a chance. The PR now includes both Milvus memory service support and the Milvus RAG toolset, with deterministic Milvus Lite coverage plus opt-in live Milvus Lite / Zilliz Cloud embedding-provider E2E checks. Current checks are passing. |
|
Closing this PR because the Milvus ADK integration is now maintained as the standalone The companion docs PR has been updated to point to the standalone package instead of this community-repo implementation. This avoids maintaining two parallel integration surfaces. Happy to revisit a smaller wrapper or adapter here later if the community repo wants an in-repo entry point. |
Summary
MilvusMemoryService, aBaseMemoryServiceimplementation backed by Milvus.app_nameanduser_id, and configurable Milvus URI/token/database/collection settings.milvusoptional extra, sample documentation, unit tests, and opt-in end-to-end tests for Milvus Lite and Zilliz Cloud.Closes #69
Testing
uv run pytest tests/unittests/memory/test_milvus_memory_service.pyRUN_MILVUS_LITE_E2E=1 uv run pytest tests/integration/memory/test_milvus_memory_service_e2e.py::test_milvus_lite_memory_e2e -quv run pytest tests/integration/memory/test_milvus_memory_service_e2e.py::test_zilliz_cloud_memory_e2e -quv run pytest